Move EOF to Osaka #1060
Move EOF to Osaka #1060
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 94.21% 94.22% +0.01%
==========================================
Files 158 158
Lines 17054 17054
==========================================
+ Hits 16067 16069 +2
+ Misses 987 985 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
EEST tests fixed in ethereum/execution-spec-tests#907, pointed CI to our fork of |
pdobacz
force-pushed
the
eofsaka
branch
2 times, most recently
from
2418b9e to
fb2c4ba
Compare
| @@ -458,7 +454,7 @@ jobs: | |||
| working_directory: ~/build | |||
| command: > | |||
| bin/evmone-blockchaintest | |||
| --gtest_filter='-*StateTests/stEOF/*.*:*StateTests/stEIP2537.*' | |||
There was a problem hiding this comment.
There is nothing left here. We should remove this step. https://github.com/ethereum/tests/tree/develop/EIPTests/StateTests
There was a problem hiding this comment.
There was a problem hiding this comment.
and https://github.com/ipsilon/tests/tree/eof-osaka-20241028/EIPTests/BlockchainTests/bcExample
(note the former is skipped, but the latter passes)
There was a problem hiding this comment.
ha, and third: BTW, why do we exclude 2537? they pass
There was a problem hiding this comment.
2537 is covered by EEST. I would also ignore "examples". We are migrating away from ethereum/tests so let's limit the exposure. But I can do this in a separate PR with proper comment.
There was a problem hiding this comment.
yea, separate PR seems cleaner
Yeah, I think squash merge is ok here |
As title. This ended up just being a Find-Replace PR, I'm not sure if I'm missing something more profound here.
Start as draft as I'm still figuring out why we don't fill EEST (possibly problem on EEST end)EDIT: EEST tests fixed in ethereum/execution-spec-tests#907, pointed CI to our fork of
ethereum/testsafter having bumped to Osaka and removed migrated tests (ethereum/tests#1410)